Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block Patterns: Cover block behaviour changed as of WP 5.9 and affects Subscribe patterns #1014

Closed
laurelfulford opened this issue Jan 14, 2022 · 1 comment · Fixed by #1017
Assignees
Labels
bug Something isn't working released on @alpha wp 5.9

Comments

@laurelfulford
Copy link
Contributor

In WordPress 5.9, the Cover Block behaviour changes -- originally, text inside the block would always default to white. This made sense in early days when the block always had a dark overlay, but now that you can make it lighter, it no longer makes sense.

The block now will smartly switch to a darker default text on lighter images. Understandably, this isn't perfect, and the text can sometimes be too dark -- this is happening with the text and default image used in our subscribe patterns:

image

The patterns need to be updated to switch the heading block text to white to have sufficient contrast going forward.

@matticbot
Copy link
Contributor

🎉 This issue has been resolved in version 1.45.0-alpha.6 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released on @alpha wp 5.9
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants