Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Subscribe patterns for WordPress 5.9 #1017

Merged
merged 1 commit into from
Jan 17, 2022
Merged

Update Subscribe patterns for WordPress 5.9 #1017

merged 1 commit into from
Jan 17, 2022

Conversation

laurelfulford
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

In WordPress 5.9, the Cover block has the ability to "smartly" figure out whether the image in it is dark or light and change the text colour accordingly; unfortunately, it does not get this quite right for the Subscribe block patterns, and the text does not have sufficient contrast.

This PR makes the text in Subscribe pattern #2 and #3 white to fix this.

Closes #1014

How to test the changes in this Pull Request:

  1. Start with a test site running the WordPress 5.9 RC.
  2. Open the pattern library and insert Subscribe patterns Polyfill all view scripts #2 and Blocks: Make webpack.config.extensions.js extend calypso-build's #3 in the editor; note both have dark text against a pretty dark Cover block image, both in the editor and in the pattern preview:

image

  1. Apply the PR and run npm run build.
  2. Reopen the pattern preview and reinsert the blocks; confirm that the heading text is now white and legible, and that no errors are thrown:

image

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@laurelfulford laurelfulford requested a review from a team January 17, 2022 00:13
miguelpeixe
miguelpeixe approved these changes Jan 17, 2022
View reviewed changes
Copy link
Member

@miguelpeixe miguelpeixe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@laurelfulford
Copy link
Contributor Author

Thanks @miguelpeixe!

@laurelfulford laurelfulford merged commit 5cef283 into master Jan 17, 2022
@laurelfulford laurelfulford deleted the fix/1014-subscribe-pattern-color branch January 17, 2022 18:42
matticbot pushed a commit that referenced this pull request Jan 18, 2022
@semantic-release-bot
chore(release): 1.45.0-alpha.6 [skip ci]
785c122 
# [1.45.0-alpha.6](v1.45.0-alpha.5...v1.45.0-alpha.6) (2022-01-18)

### Bug Fixes

* update columns styles for WordPress 5.9 ([#1020](#1020)) ([a38ce32](a38ce32))
* update Subscribe patterns for WordPress 5.9 ([#1017](#1017)) ([5cef283](5cef283))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.45.0-alpha.6 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Jan 19, 2022
@semantic-release-bot
chore(release): 1.45.0 [skip ci]
7d17a00 
# [1.45.0](v1.44.1...v1.45.0) (2022-01-19)

### Bug Fixes

* add Author List block to manifest of blocks to build in production ([#1011](#1011)) ([abd5b7c](abd5b7c))
* add simplified CSS class to carousel to reduce style size ([#983](#983)) ([f8b1b0a](f8b1b0a))
* **author-list:** user query when CAP is not installed ([#1015](#1015)) ([e798d9b](e798d9b))
* force alpha rebuild ([1e55132](1e55132))
* lint errors ([#1010](#1010)) ([c50a1f5](c50a1f5))
* re-add space between stacked columns ([#1022](#1022)) ([d560199](d560199))
* update columns styles for WordPress 5.9 ([#1020](#1020)) ([a38ce32](a38ce32))
* update Subscribe patterns for WordPress 5.9 ([#1017](#1017)) ([5cef283](5cef283))

### Features

* author list block ([#947](#947)) ([b98b8b8](b98b8b8))
* **donate-stripe:** hide fee checkbox if fees are zero ([#985](#985)) ([04e7892](04e7892))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelpeixe miguelpeixe miguelpeixe approved these changes

Assignees
No one assigned
Labels
released on @alpha [Status] Approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Block Patterns: Cover block behaviour changed as of WP 5.9 and affects Subscribe patterns
3 participants
@laurelfulford @matticbot @miguelpeixe