Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(author-list): user query when CAP is not installed #1015

Merged
merged 1 commit into from
Jan 14, 2022
Merged

fix(author-list): user query when CAP is not installed #1015

merged 1 commit into from
Jan 14, 2022

Conversation

dkoo
Copy link
Contributor

@dkoo dkoo commented Jan 14, 2022

All Submissions:

Changes proposed in this Pull Request:

Fixes a bug with fetching WP users if the Co-Authors Plus plugin isn't active.

How to test the changes in this Pull Request:

  1. Deactivate the CAP plugin.
  2. On master, add an Author List block. Observe that the block displays nothing in both the editor and on the front-end.
  3. Check out this branch, refresh both, and confirm that the block now shows WP users as expected.
  4. Activate the CAP plugin, refresh both, confirm that the block now shows both WP users and CAP guest authors.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@dkoo dkoo added bug Something isn't working [Status] Needs Review labels Jan 14, 2022
@dkoo dkoo requested review from laurelfulford and a team January 14, 2022 23:34
@dkoo dkoo self-assigned this Jan 14, 2022
laurelfulford
laurelfulford approved these changes Jan 14, 2022
View reviewed changes
Copy link
Contributor

@laurelfulford laurelfulford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🎉 Tested with and without the Co-Authors plus plugin enabled -- with it disabled, authors are now being displayed in the editor and front-end, and when it's enabled, the Guest Authors are added to the mix.

@dkoo dkoo merged commit e798d9b into master Jan 14, 2022
@dkoo dkoo deleted the fix/author-list-no-cap branch January 14, 2022 23:45
matticbot pushed a commit that referenced this pull request Jan 14, 2022
@semantic-release-bot
chore(release): 1.45.0-alpha.5 [skip ci]
fe7d014 
# [1.45.0-alpha.5](v1.45.0-alpha.4...v1.45.0-alpha.5) (2022-01-14)

### Bug Fixes

* **author-list:** user query when CAP is not installed ([#1015](#1015)) ([e798d9b](e798d9b))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.45.0-alpha.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Jan 19, 2022
@semantic-release-bot
chore(release): 1.45.0 [skip ci]
7d17a00 
# [1.45.0](v1.44.1...v1.45.0) (2022-01-19)

### Bug Fixes

* add Author List block to manifest of blocks to build in production ([#1011](#1011)) ([abd5b7c](abd5b7c))
* add simplified CSS class to carousel to reduce style size ([#983](#983)) ([f8b1b0a](f8b1b0a))
* **author-list:** user query when CAP is not installed ([#1015](#1015)) ([e798d9b](e798d9b))
* force alpha rebuild ([1e55132](1e55132))
* lint errors ([#1010](#1010)) ([c50a1f5](c50a1f5))
* re-add space between stacked columns ([#1022](#1022)) ([d560199](d560199))
* update columns styles for WordPress 5.9 ([#1020](#1020)) ([a38ce32](a38ce32))
* update Subscribe patterns for WordPress 5.9 ([#1017](#1017)) ([5cef283](5cef283))

### Features

* author list block ([#947](#947)) ([b98b8b8](b98b8b8))
* **donate-stripe:** hide fee checkbox if fees are zero ([#985](#985)) ([04e7892](04e7892))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurelfulford laurelfulford laurelfulford approved these changes

Assignees

@dkoo dkoo

Labels
bug Something isn't working released on @alpha [Status] Approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dkoo @matticbot @laurelfulford