Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Columns Block: Investigate removing Newspack-specific styles #1065

Closed
laurelfulford opened this issue Mar 10, 2022 · 1 comment
Closed

Columns Block: Investigate removing Newspack-specific styles #1065

laurelfulford opened this issue Mar 10, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@laurelfulford
Copy link
Contributor

Early on, we added some Columns styles to the Newspack Blocks plugin, to override how the columns wrapped in Gutenberg's default styles.

These styles have caused issues since then -- both when the Columns block was updated in WP 5.9, and when they clash with plugins (like the Publisher Media Kit plugin).

We should test and see if we can remove these styles at this point -- if we can, it could make things easier to maintain down the road.

@laurelfulford
Copy link
Contributor Author

Closed with #1133.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant