Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 3 new subscribe patterns #1091

Merged
merged 1 commit into from
Apr 8, 2022
Merged

Conversation

thomasguillot
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

This PR adds 3 new subscribe patterns. These are slightly different from the previous ones. They use templateLock: all on the main Group and lock:{remove:false} on the heading and copy.

This means that these patterns are kind of locked yet there's still some flexibility with its customisation.

How to test the changes in this Pull Request:

  1. Switch to this branch
  2. Insert the various patterns to a page and/or a prompt

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Copy link
Contributor

@laurelfulford laurelfulford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These new patterns are really looking nice! 🎉

The template locking seems to work well in my testing -- I was able to remove and edit heading, paragraph, and image blocks, and swap the image in the media & text block, but not actually delete the media & text, columns or contact blocks.

The inability to add blocks tripped me up a bit, even though I knew the templateLock was in place -- it felt a little weird that I couldn't add a second paragraph, or re-add one once I deleted it. This functions as expected, though, and AFAIK this is as nuanced as locking gets right now.

I don't think this is a blocker, but it might be a good thing to keep tabs on and see what the general feedback is -- I could be finding problems that won't come up in the real world 🙂 And worst-case, the lock can be removed by using the code editor (the other way is to "Ungroup" the group block, but that's not a good idea for these!).

@thomasguillot thomasguillot merged commit 1d7f688 into master Apr 8, 2022
@thomasguillot thomasguillot deleted the add/subscribe-patterns branch April 8, 2022 08:24
@thomasguillot
Copy link
Contributor Author

re-add one once I deleted it

Yep that's kind of the downside of templateLock. But I think this is better than allowing user to mess with the pattern 😃

matticbot pushed a commit that referenced this pull request Apr 14, 2022
# [1.48.0-alpha.1](v1.47.2...v1.48.0-alpha.1) (2022-04-14)

### Features

* add 3 new subscribe patterns ([#1091](#1091)) ([1d7f688](1d7f688))
* **donate-streamlined:** set user ID on Stripe client ([#1095](#1095)) ([e9f4bd5](e9f4bd5))
* publish on npm when releasing ([e77fdf6](e77fdf6)), closes [#849](#849)
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.48.0-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Apr 18, 2022
# [1.48.0](v1.47.2...v1.48.0) (2022-04-18)

### Features

* add 3 new subscribe patterns ([#1091](#1091)) ([1d7f688](1d7f688))
* **donate-streamlined:** set user ID on Stripe client ([#1095](#1095)) ([e9f4bd5](e9f4bd5))
* publish on npm when releasing ([e77fdf6](e77fdf6)), closes [#849](#849)
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.48.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants