Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Homepage Posts & Carousel blocks: Improve alt text on images linked to posts #1118

Merged
merged 2 commits into from
May 3, 2022
Merged

Homepage Posts & Carousel blocks: Improve alt text on images linked to posts #1118

merged 2 commits into from
May 3, 2022

Conversation

laurelfulford
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

This PR replaces the author-provided alt text on the linked featured images with the post title. This helps give some context to where the link actually goes, to improve accessibility. Otherwise, descriptive text in this context isn't as helpful because it doesn't tell someone navigating the site via screenreader where the link on the image goes.

Closes #1115

How to test the changes in this Pull Request:

  1. Apply the PR.
  2. Add a Homepage Posts and Post Carousel block to a page; make sure each block has at least one post with a featured image.
  3. Publish.
  4. Inspect the source and confirm that the alt text on the featured image matches the post title.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@laurelfulford laurelfulford requested a review from a team as a code owner April 22, 2022 23:27
dkoo
dkoo approved these changes May 3, 2022
View reviewed changes
Copy link
Contributor

@dkoo dkoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@laurelfulford
Copy link
Contributor Author

Thanks @dkoo!

@laurelfulford laurelfulford merged commit d98f8ad into master May 3, 2022
@laurelfulford laurelfulford deleted the fix/1115-improve-linked-image-alt branch May 3, 2022 18:44
matticbot pushed a commit that referenced this pull request May 5, 2022
@semantic-release-bot
chore(release): 1.50.0-alpha.1 [skip ci]
202be20 
# [1.50.0-alpha.1](v1.49.0...v1.50.0-alpha.1) (2022-05-05)

### Features

* improve alt text on images linked to posts ([#1118](#1118)) ([d98f8ad](d98f8ad))
* update donate block styles to support keyboard navigation ([#1117](#1117)) ([0f65dd7](0f65dd7))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.50.0-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request May 18, 2022
@semantic-release-bot
chore(release): 1.50.0 [skip ci]
fc9d49a 
# [1.50.0](v1.49.0...v1.50.0) (2022-05-18)

### Features

* improve alt text on images linked to posts ([#1118](#1118)) ([d98f8ad](d98f8ad))
* update donate block styles to support keyboard navigation ([#1117](#1117)) ([0f65dd7](0f65dd7))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.50.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkoo dkoo dkoo approved these changes

Assignees
No one assigned
Labels
released on @alpha released [Status] Approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Homepage Posts & Carousel blocks: change alt text on linked image to improve accessibility
3 participants
@laurelfulford @matticbot @dkoo