Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/customise donate button streamlined #1219

Merged
merged 3 commits into from
Aug 1, 2022

Conversation

adekbadek
Copy link
Member

All Submissions:

Changes proposed in this Pull Request:

Closes #1145.

How to test the changes in this Pull Request:

  1. On master, insert a streamlined Donate block (Stripe has to be set as the Reader Revenue platform)
  2. Switch to this branch, observe the block rendering as before
  3. In the editor, observe the "Donate with card" button is editable, and that the payment request (Apple/Google Pay) has a select allowing to choose a variant
  4. Observe the credit card button text and payment request button variant are reflected on the frontend*

* for the latter, you'll need a browser configured for such payments, which can be done with browserstack.com

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@adekbadek adekbadek merged commit 8bda0f0 into master Aug 1, 2022
@adekbadek adekbadek deleted the feat/customise-donate-button-streamlined branch August 1, 2022 06:37
matticbot pushed a commit that referenced this pull request Aug 5, 2022
# [1.55.0-alpha.1](v1.54.1...v1.55.0-alpha.1) (2022-08-05)

### Features

* **donate:** add current_page_url to client metadata ([32e18a4](32e18a4))
* **donate:** customise donate button texts ([#1219](#1219)) ([8bda0f0](8bda0f0))
* **donate:** mobile style; UX tweaks ([#1201](#1201)) ([65a1285](65a1285))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.55.0-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Aug 10, 2022
# [1.56.0-alpha.1](v1.55.0...v1.56.0-alpha.1) (2022-08-10)

### Features

* **donate:** add current_page_url to client metadata ([32e18a4](32e18a4))
* **donate:** customise donate button texts ([#1219](#1219)) ([8bda0f0](8bda0f0))
* **donate:** mobile style; UX tweaks ([#1201](#1201)) ([65a1285](65a1285))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.56.0-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Aug 16, 2022
# [1.56.0](v1.55.0...v1.56.0) (2022-08-16)

### Bug Fixes

* ensure amount is always defined for totalAmount calculation ([#1227](#1227)) ([b1910dc](b1910dc))
* force a new alpha build ([8bf60a8](8bf60a8))
* merge conflicts and force new build again ([b9020c6](b9020c6))
* resolve merge conflicts with [#1234](#1234) ([15fe247](15fe247))

### Features

* **donate:** add current_page_url to client metadata ([32e18a4](32e18a4))
* **donate:** customise donate button texts ([#1219](#1219)) ([8bda0f0](8bda0f0))
* **donate:** mobile style; UX tweaks ([#1201](#1201)) ([65a1285](65a1285))
* **donate:** refresh reader authentication ([#1236](#1236)) ([f21904b](f21904b))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.56.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to change title of button in donate block
3 participants