fix: ensure amount is always defined for totalAmount calculation #1227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miguelpeixe
approved these changes
Aug 12, 2022
|
🎉 This PR is included in version 1.56.0-alpha.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
matticbot
pushed a commit
that referenced
this pull request
Aug 12, 2022
# [1.56.0-alpha.2](v1.56.0-alpha.1...v1.56.0-alpha.2) (2022-08-12) ### Bug Fixes * ensure amount is always defined for totalAmount calculation ([#1227](#1227)) ([b1910dc](b1910dc)) * resolve merge conflicts with [#1234](#1234) ([15fe247](15fe247)) ### Features * **donate:** refresh reader authentication ([#1236](#1236)) ([f21904b](f21904b))
matticbot
pushed a commit
that referenced
this pull request
Aug 16, 2022
# [1.56.0](v1.55.0...v1.56.0) (2022-08-16) ### Bug Fixes * ensure amount is always defined for totalAmount calculation ([#1227](#1227)) ([b1910dc](b1910dc)) * force a new alpha build ([8bf60a8](8bf60a8)) * merge conflicts and force new build again ([b9020c6](b9020c6)) * resolve merge conflicts with [#1234](#1234) ([15fe247](15fe247)) ### Features * **donate:** add current_page_url to client metadata ([32e18a4](32e18a4)) * **donate:** customise donate button texts ([#1219](#1219)) ([8bda0f0](8bda0f0)) * **donate:** mobile style; UX tweaks ([#1201](#1201)) ([65a1285](65a1285)) * **donate:** refresh reader authentication ([#1236](#1236)) ([f21904b](f21904b))
|
🎉 This PR is included in version 1.56.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Looks like #1201 introduced a small bug due to removing the fallback/default value of
0foramountwhen calculating the total donation amount plus Stripe fees.Closes #1226.
How to test the changes in this Pull Request:
Confirm that #1226 is not replicable.
Other information: