Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the pattern's icon with Newspack logo #419

Merged
merged 1 commit into from
Mar 23, 2020

Conversation

thomasguillot
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

Gutenberg 7.7 introduces a pattern library that lives in the pinned sidebar. The icon is very similar to the one we use for the Newspack Patterns.
This PR replaces the Material icon with our logo.

How to test the changes in this Pull Request:

  1. Make sure you have Gutenberg 7.7+ installed.
  2. Edit a page/post
  3. Notice the 2 similar looking icons in the top right hand corner of the editor
  4. Switch to this branch and refresh the page/post.
  5. Is it any better? Is is less confusing?

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Copy link
Contributor

@jeffersonrabb jeffersonrabb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The icon seems to be rendering for me as a solid circle:

Screen Shot 2020-03-22 at 7 52 25 PM

@jeffersonrabb
Copy link
Contributor

The icon seems to be rendering for me as a solid circle:

After feedback from @thomasguillot that he couldn't reproduce this problem, I re-tested and the icon rendered correctly. Unclear why I had trouble before, but looks good now.

@thomasguillot thomasguillot merged commit 8532c6f into master Mar 23, 2020
@thomasguillot thomasguillot deleted the update/pattern-icon-sidebar branch March 23, 2020 11:09
matticbot pushed a commit that referenced this pull request Mar 24, 2020
# [1.2.0](v1.1.0...v1.2.0) (2020-03-24)

### Bug Fixes

* make sure styles hiding updated date doesn't hide all dates  ([#406](#406)) ([d1bb53c](d1bb53c))

### Features

* display subscribe pattern when mailchimp is inactive ([#418](#418)) ([09716c1](09716c1))
* update the pattern's icon with newspack logo ([#419](#419)) ([8532c6f](8532c6f))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants