Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display subscribe pattern when Mailchimp is inactive #418

Merged
merged 1 commit into from
Mar 23, 2020
Merged

Display subscribe pattern when Mailchimp is inactive #418

merged 1 commit into from
Mar 23, 2020

Conversation

thomasguillot
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

This tiny PR makes sure that the Subscribe patterns are always being displayed and not just when Mailchimp is active. Because... how would you active Mailchimp if it's not available 🙄

How to test the changes in this Pull Request:

  1. On a site with Mailchimp not active, in a page, open the Newspack Patterns, do you see the Subscribe patterns? (you shouldn't)
  2. Switch to this branch.
  3. Try again (this time you should see the patterns)

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

jeffersonrabb
jeffersonrabb approved these changes Mar 23, 2020
View reviewed changes
Copy link
Contributor

@jeffersonrabb jeffersonrabb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@thomasguillot thomasguillot merged commit 09716c1 into master Mar 23, 2020
@thomasguillot thomasguillot deleted the update/subscribe-pattern-check branch March 23, 2020 08:09
matticbot pushed a commit that referenced this pull request Mar 24, 2020
@semantic-release-bot
chore(release): 1.2.0 [skip ci]
96474ab 
# [1.2.0](v1.1.0...v1.2.0) (2020-03-24)

### Bug Fixes

* make sure styles hiding updated date doesn't hide all dates  ([#406](#406)) ([d1bb53c](d1bb53c))

### Features

* display subscribe pattern when mailchimp is inactive ([#418](#418)) ([09716c1](09716c1))
* update the pattern's icon with newspack logo ([#419](#419)) ([8532c6f](8532c6f))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffersonrabb jeffersonrabb jeffersonrabb approved these changes

Assignees
No one assigned
Labels
released [Status] Approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thomasguillot @matticbot @jeffersonrabb