Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: editable donate button text #535

Merged
merged 1 commit into from
Jun 25, 2020
Merged

feat: editable donate button text #535

merged 1 commit into from
Jun 25, 2020

Conversation

jeffersonrabb
Copy link
Contributor

@jeffersonrabb jeffersonrabb commented Jun 24, 2020 •
edited
Loading

All Submissions:

Changes proposed in this Pull Request:

Makes the text of the Donate button editable.

Closes #361

How to test the changes in this Pull Request:

  1. Add Donate block to a post.
  2. Edit the button text in place.
  3. Publish, verify the text change is visible in frontend.
  4. Try with manual settings and Newspack-set defaults, verify all works as expected.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@jeffersonrabb jeffersonrabb self-assigned this Jun 24, 2020
claudiulodro
claudiulodro approved these changes Jun 25, 2020
View reviewed changes
Copy link
Contributor

@claudiulodro claudiulodro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works great, and your solution is elegant. Good work!

@jeffersonrabb jeffersonrabb merged commit 6261e3f into master Jun 25, 2020
matticbot pushed a commit that referenced this pull request Jun 30, 2020
@semantic-release-bot
chore(release): 1.9.0 [skip ci]
eca196c 
# [1.9.0](v1.8.1...v1.9.0) (2020-06-30)

### Bug Fixes

* make load more button styles more specific ([#527](#527)) ([68089aa](68089aa))
* php warnings, phpcs warnings ([#540](#540)) ([23b34a1](23b34a1))

### Features

* editable donate button text ([#535](#535)) ([6261e3f](6261e3f))
* exclude current post in homepage posts block ([#539](#539)) ([030024d](030024d))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.9.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claudiulodro claudiulodro claudiulodro approved these changes

Assignees

@jeffersonrabb jeffersonrabb

Labels
released [Status] Approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Donate Block: Ability to change 'Donate Now!' button text
3 participants
@jeffersonrabb @matticbot @claudiulodro