Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: php warnings, phpcs warnings in donate block #540

Merged
merged 1 commit into from
Jun 30, 2020
Merged

fix: php warnings, phpcs warnings in donate block #540

merged 1 commit into from
Jun 30, 2020

Conversation

jeffersonrabb
Copy link
Contributor

@jeffersonrabb jeffersonrabb commented Jun 30, 2020 •
edited
Loading

All Submissions:

Changes proposed in this Pull Request:

Resolves a few PHP and PHPCS warnings in the Donate block. There should be no change to the block's functionality.

How to test the changes in this Pull Request:

  1. On master, add Donate block to post, toggle to "configure manually." Publish and view the post.
  2. In PHP error log, observe many notices like this: PHP Notice: Undefined index: items in /srv/www/wordpress-simple/public_html/wp-includes/rest-api.php on line 1251
  3. Switch to this branch and refresh the page.
  4. Observe the notices are gone.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@jeffersonrabb jeffersonrabb changed the title fix: php warnings, phpcs warnings fix: php warnings, phpcs warnings in donate block Jun 30, 2020
@jeffersonrabb jeffersonrabb requested a review from dkoo June 30, 2020 12:46
@jeffersonrabb jeffersonrabb self-assigned this Jun 30, 2020
dkoo
dkoo approved these changes Jun 30, 2020
View reviewed changes
Copy link
Contributor

@dkoo dkoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and looks good!

@jeffersonrabb jeffersonrabb merged commit 23b34a1 into master Jun 30, 2020
@jeffersonrabb jeffersonrabb deleted the fix/php-warnings-and-phpcs branch June 30, 2020 19:44
matticbot pushed a commit that referenced this pull request Jun 30, 2020
@semantic-release-bot
chore(release): 1.9.0 [skip ci]
eca196c 
# [1.9.0](v1.8.1...v1.9.0) (2020-06-30)

### Bug Fixes

* make load more button styles more specific ([#527](#527)) ([68089aa](68089aa))
* php warnings, phpcs warnings ([#540](#540)) ([23b34a1](23b34a1))

### Features

* editable donate button text ([#535](#535)) ([6261e3f](6261e3f))
* exclude current post in homepage posts block ([#539](#539)) ([030024d](030024d))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.9.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkoo dkoo dkoo approved these changes

Assignees

@jeffersonrabb jeffersonrabb

Labels
released [Status] Approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeffersonrabb @matticbot @dkoo