Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Homepage Posts: Add article class for post types #679

Merged
merged 1 commit into from
Jan 26, 2021
Merged

Homepage Posts: Add article class for post types #679

merged 1 commit into from
Jan 26, 2021

Conversation

laurelfulford
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

This PR adds a CSS class with the format .type-XXXX, for the current post's post type.

Closes #658.

How to test the changes in this Pull Request:

  1. Add a homepage post block to a page; enable both posts and pages for the block, and make sure you have at least one of each in the current query, and publish.
  2. Apply the PR.
  3. Inspect the articles on the front end and in the editor; confirm that the posts have the CSS class type-post on the <article> tag, and the pages have the CSS class type-page on the <article> tag.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

dkoo
dkoo approved these changes Jan 26, 2021
View reviewed changes
Copy link
Contributor

@dkoo dkoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@laurelfulford
Copy link
Contributor Author

Thanks Derrick! 🙌

@laurelfulford laurelfulford merged commit f493a01 into master Jan 26, 2021
matticbot pushed a commit that referenced this pull request Jan 28, 2021
@semantic-release-bot
chore(release): 1.19.0-alpha.1 [skip ci]
7345bd5 
# [1.19.0-alpha.1](v1.18.1...v1.19.0-alpha.1) (2021-01-28)

### Bug Fixes

* carousel block renders authors like homepage articles ([#680](#680)) ([0b574c7](0b574c7))
* in specific posts mode, post order should match input order ([#681](#681)) ([1cfea8d](1cfea8d))

### Features

* add article class for post types ([#679](#679)) ([f493a01](f493a01))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.19.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Jan 28, 2021
@semantic-release-bot
chore(release): 1.19.0 [skip ci]
7eb0045 
# [1.19.0](v1.18.1...v1.19.0) (2021-01-28)

### Bug Fixes

* carousel block renders authors like homepage articles ([#680](#680)) ([0b574c7](0b574c7))
* in specific posts mode, post order should match input order ([#681](#681)) ([1cfea8d](1cfea8d))

### Features

* add article class for post types ([#679](#679)) ([f493a01](f493a01))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.19.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkoo dkoo dkoo approved these changes

@jeffersonrabb jeffersonrabb Awaiting requested review from jeffersonrabb

Assignees
No one assigned
Labels
released on @alpha released [Status] Approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Homepage Posts: add class for post type
3 participants
@laurelfulford @matticbot @dkoo