Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: carousel block renders authors like homepage articles #680

Merged
merged 1 commit into from
Jan 28, 2021
Merged

fix: carousel block renders authors like homepage articles #680

merged 1 commit into from
Jan 28, 2021

Conversation

jeffersonrabb
Copy link
Contributor

@jeffersonrabb jeffersonrabb commented Jan 27, 2021 •
edited
Loading

All Submissions:

Changes proposed in this Pull Request:

This should cause the Carousel block to render authors exactly like Homepage Posts on the front end.

Closes #456

How to test the changes in this Pull Request:

  1. Publish a series of posts with different author configurations, including a) more than one guest author, b) one guest author, c) one WordPress author, d) one guest author, one WordPress author, e) any of the above with avatars.
  2. Create two pages, one with a Posts Carousel block and one with a Homepage Posts block.
  3. Compare the two in the editor, verify the author displays are identical (this should be true on master).
  4. Compare the two on front end. On master the Posts Carousel block's author display is broken, on this branch it should be identical to Homepage Posts.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@jeffersonrabb jeffersonrabb self-assigned this Jan 27, 2021
philipjohn
philipjohn approved these changes Jan 27, 2021
View reviewed changes
Copy link
Contributor

@philipjohn philipjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, works nicely, and handles multiple authors 👍

dkoo
dkoo approved these changes Jan 28, 2021
View reviewed changes
Copy link
Contributor

@dkoo dkoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@dkoo dkoo merged commit 0b574c7 into master Jan 28, 2021
@dkoo dkoo deleted the fix/carousel-authors branch January 28, 2021 22:56
matticbot pushed a commit that referenced this pull request Jan 28, 2021
@semantic-release-bot
chore(release): 1.19.0-alpha.1 [skip ci]
7345bd5 
# [1.19.0-alpha.1](v1.18.1...v1.19.0-alpha.1) (2021-01-28)

### Bug Fixes

* carousel block renders authors like homepage articles ([#680](#680)) ([0b574c7](0b574c7))
* in specific posts mode, post order should match input order ([#681](#681)) ([1cfea8d](1cfea8d))

### Features

* add article class for post types ([#679](#679)) ([f493a01](f493a01))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.19.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Jan 28, 2021
@semantic-release-bot
chore(release): 1.19.0 [skip ci]
7eb0045 
# [1.19.0](v1.18.1...v1.19.0) (2021-01-28)

### Bug Fixes

* carousel block renders authors like homepage articles ([#680](#680)) ([0b574c7](0b574c7))
* in specific posts mode, post order should match input order ([#681](#681)) ([1cfea8d](1cfea8d))

### Features

* add article class for post types ([#679](#679)) ([f493a01](f493a01))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.19.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philipjohn philipjohn philipjohn approved these changes

@dkoo dkoo dkoo approved these changes

@adekbadek adekbadek Awaiting requested review from adekbadek

Assignees

@jeffersonrabb jeffersonrabb

Labels
[Block] Carousel bug Something isn't working released on @alpha released [Status] Approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Article Carousel: Multiple Authors aren't shown on front end
4 participants
@jeffersonrabb @matticbot @philipjohn @dkoo