-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(donate-stripe): hide fee checkbox if fees are zero #985
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I was testing this I think I caught a math error in the function computing the fee amount. Also have a suggestion on rendering the fee on the front-end as a formatted currency string instead of as a float.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good 👍
🎉 This PR is included in version 1.45.0-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
# [1.45.0](v1.44.1...v1.45.0) (2022-01-19) ### Bug Fixes * add Author List block to manifest of blocks to build in production ([#1011](#1011)) ([abd5b7c](abd5b7c)) * add simplified CSS class to carousel to reduce style size ([#983](#983)) ([f8b1b0a](f8b1b0a)) * **author-list:** user query when CAP is not installed ([#1015](#1015)) ([e798d9b](e798d9b)) * force alpha rebuild ([1e55132](1e55132)) * lint errors ([#1010](#1010)) ([c50a1f5](c50a1f5)) * re-add space between stacked columns ([#1022](#1022)) ([d560199](d560199)) * update columns styles for WordPress 5.9 ([#1020](#1020)) ([a38ce32](a38ce32)) * update Subscribe patterns for WordPress 5.9 ([#1017](#1017)) ([5cef283](5cef283)) ### Features * author list block ([#947](#947)) ([b98b8b8](b98b8b8)) * **donate-stripe:** hide fee checkbox if fees are zero ([#985](#985)) ([04e7892](04e7892))
All Submissions:
Changes proposed in this Pull Request:
Allows hiding of cover-fees checkbox (#928) if the fees amount to 0.
How to test the changes in this Pull Request:
Follow steps in Automattic/newspack-plugin#1376
Other information: