Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new subscribe pattern #1142

Merged
merged 2 commits into from
May 28, 2022
Merged

Add new subscribe pattern #1142

merged 2 commits into from
May 28, 2022

Conversation

thomasguillot
Copy link
Contributor

@thomasguillot thomasguillot commented May 26, 2022 •
edited
Loading

All Submissions:

Changes proposed in this Pull Request:

This is a very simple pattern, 2 columns (70 - 30) with paragraph and mailchimp block. It's intended for "above header" inline prompts.

How to test the changes in this Pull Request:

  1. Switch to this branch
  2. Apply Newspack theme PR: Add custom style to subscribe pattern 10 newspack-theme#1818
  3. Create new above header prompt
  4. Insert this pattern
  5. Publish

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@thomasguillot thomasguillot requested a review from a team as a code owner May 26, 2022 11:34
@thomasguillot thomasguillot mentioned this pull request May 26, 2022
Merged
6 tasks
@laurelfulford laurelfulford self-requested a review May 27, 2022 23:02
laurelfulford
laurelfulford approved these changes May 28, 2022
View reviewed changes
Copy link
Contributor

@laurelfulford laurelfulford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me overall!

I have some non-blocking feedback that probably says more about my eyesight than anything: this particular arrow symbol feels a bit small to me 😅 A big part of it is the font size, which we're stuck with; I did find some heavier options (❯ ➔ ➤) but I'm not sure they quite fit as well with the overall look. Again, definitely not a blocker, especially since you can still edit the button!

@thomasguillot
Copy link
Contributor Author

This looks good to me overall!

I have some non-blocking feedback that probably says more about my eyesight than anything: this particular arrow symbol feels a bit small to me 😅 A big part of it is the font size, which we're stuck with; I did find some heavier options (❯ ➔ ➤) but I'm not sure they quite fit as well with the overall look. Again, definitely not a blocker, especially since you can still edit the button!

I went for the most basic arrow because I wasn't sure if all the fonts/languages were supporting all the options. Ideally, I wanted to use an SVG but it'd make things waaaaaay too overcomplicated.

@thomasguillot thomasguillot merged commit 97d632e into master May 28, 2022
@thomasguillot thomasguillot deleted the add/pattern-subscribe-10 branch May 28, 2022 12:34
@laurelfulford
Copy link
Contributor

I went for the most basic arrow because I wasn't sure if all the fonts/languages were supporting all the options. Ideally, I wanted to use an SVG but it'd make things waaaaaay too overcomplicated.

Ah, that makes sense! 👍

matticbot pushed a commit that referenced this pull request Jun 2, 2022
@semantic-release-bot
chore(release): 1.52.0-alpha.1 [skip ci]
b12cec4 
# [1.52.0-alpha.1](v1.51.0...v1.52.0-alpha.1) (2022-06-02)

### Bug Fixes

* correct donate block tab spacing in editor ([#1153](#1153)) ([c17221f](c17221f))
* disambiguate WP users vs. guest authors with same ID ([#1143](#1143)) ([d3c5920](d3c5920))
* echo closing link tags on sponsor bylines ([#1152](#1152)) ([f80893f](f80893f))
* remove custom column block styles ([#1133](#1133)) ([bd79783](bd79783))
* skipped linked images when navigating blocks by keyboard ([#1144](#1144)) ([8975787](8975787))

### Features

* add new subscribe pattern ([#1142](#1142)) ([97d632e](97d632e))
* remove support for the Aside post format ([#1139](#1139)) ([9f9cdf4](9f9cdf4))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.52.0-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Jun 13, 2022
@semantic-release-bot
chore(release): 1.52.0 [skip ci]
7efad39 
# [1.52.0](v1.51.0...v1.52.0) (2022-06-13)

### Bug Fixes

* correct donate block tab spacing in editor ([#1153](#1153)) ([c17221f](c17221f))
* disambiguate WP users vs. guest authors with same ID ([#1143](#1143)) ([d3c5920](d3c5920))
* echo closing link tags on sponsor bylines ([#1152](#1152)) ([f80893f](f80893f))
* remove custom column block styles ([#1133](#1133)) ([bd79783](bd79783))
* skipped linked images when navigating blocks by keyboard ([#1144](#1144)) ([8975787](8975787))

### Features

* add new subscribe pattern ([#1142](#1142)) ([97d632e](97d632e))
* remove support for the Aside post format ([#1139](#1139)) ([9f9cdf4](9f9cdf4))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.52.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurelfulford laurelfulford laurelfulford approved these changes

Assignees
No one assigned
Labels
released on @alpha released [Status] Approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thomasguillot @laurelfulford @matticbot