Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/author blocks fields #1302

Merged
merged 4 commits into from
Nov 3, 2022
Merged

Feat/author blocks fields #1302

merged 4 commits into from
Nov 3, 2022

Conversation

adekbadek
Copy link
Member

All Submissions:

Changes proposed in this Pull Request:

Adds support for custom fields for post authors in Author Profile and Author List blocks.

Closes #1166

How to test the changes in this Pull Request:

Follow instructions in Automattic/newspack-plugin#2102

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@adekbadek adekbadek requested a review from a team as a code owner November 1, 2022 12:00
@adekbadek adekbadek mentioned this pull request Nov 3, 2022
Merged
6 tasks
leogermani
leogermani approved these changes Nov 3, 2022
View reviewed changes
Copy link
Contributor

@leogermani leogermani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests well

@adekbadek adekbadek merged commit 081f228 into master Nov 3, 2022
@adekbadek adekbadek deleted the feat/author-blocks-fields branch November 3, 2022 16:36
matticbot pushed a commit that referenced this pull request Nov 3, 2022
@semantic-release-bot
chore(release): 1.59.0-alpha.1 [skip ci]
9f9eb5e 
# [1.59.0-alpha.1](v1.58.1...v1.59.0-alpha.1) (2022-11-03)

### Features

* display newspack's author custom fields ([#1302](#1302)) ([081f228](081f228)), closes [#1166](#1166)
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.59.0-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Nov 14, 2022
@semantic-release-bot
chore(release): 1.59.0 [skip ci]
9bc3349 
# [1.59.0](v1.58.1...v1.59.0) (2022-11-14)

### Bug Fixes

* update newspack-scripts and CI orb ([#1304](#1304)) ([25852a9](25852a9))

### Features

* display newspack's author custom fields ([#1302](#1302)) ([081f228](081f228)), closes [#1166](#1166)
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.59.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@laurelfulford laurelfulford mentioned this pull request Nov 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leogermani leogermani leogermani approved these changes

Assignees
No one assigned
Labels
released on @alpha released [Status] Approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Author Profile & List: Add Title field
3 participants
@adekbadek @matticbot @leogermani