fix(donate): override defaults with manual config #1313
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
In the Donate block, if manually configured the manual settings don't fully override the default settings in the Reader Revenue wizard as you would expect. If a frequency is disabled in Reader Revenue, that frequency will remain disabled in a manually configured block, even if that frequency is manually enabled.
This branch tweaks the logic so that if a block is manually configured, its manual settings completely override the settings in Reader Revenue.
Also overrides the default frequency if the manual setting differs from the default settings.
Closes /0/1200550061930446/1203385734865005.
How to test the changes in this Pull Request:
Other information: