Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPB: fix author query if CAP is unavailable #1336

Merged
merged 4 commits into from
Jan 5, 2023

Conversation

adekbadek
Copy link
Member

All Submissions:

Changes proposed in this Pull Request:

Fixes an issue created in #1083, adds basic tests, and refactors some of the code.

How to test the changes in this Pull Request:

  1. On master, disable Co-Authors Plus plugin and insert the Homepage Posts block on a page
  2. Observe that querying by authors does not work (posts are not fetched)
  3. Switch to this branch, observe posts are fetched

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Copy link
Contributor

@leogermani leogermani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests well! Well done adding tests!

@adekbadek adekbadek merged commit b3ad96f into master Jan 5, 2023
@adekbadek adekbadek deleted the fix/homepage-posts-querying branch January 5, 2023 11:37
leogermani added a commit that referenced this pull request Jan 13, 2023
* build(deps-dev): bump @testing-library/dom from 8.19.0 to 8.19.1

Bumps [@testing-library/dom](https://github.com/testing-library/dom-testing-library) from 8.19.0 to 8.19.1.
- [Release notes](https://github.com/testing-library/dom-testing-library/releases)
- [Changelog](https://github.com/testing-library/dom-testing-library/blob/main/CHANGELOG.md)
- [Commits](testing-library/dom-testing-library@v8.19.0...v8.19.1)

---
updated-dependencies:
- dependency-name: "@testing-library/dom"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* fix(HPB): author query if CAP is unavailable (#1336)

* fix: make sure correct avatar is loaded when guests and users share IDs (#1339)

* feat(homepage-posts-block): filter image sizes based on the maximum image width (#1322)

* build(deps-dev): bump sirbrillig/phpcs-variable-analysis

Bumps [sirbrillig/phpcs-variable-analysis](https://github.com/sirbrillig/phpcs-variable-analysis) from 2.11.9 to 2.11.10.
- [Release notes](https://github.com/sirbrillig/phpcs-variable-analysis/releases)
- [Commits](sirbrillig/phpcs-variable-analysis@v2.11.9...v2.11.10)

---
updated-dependencies:
- dependency-name: sirbrillig/phpcs-variable-analysis
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* fix(donate-stripe): initialize Stripe only if element is visible (#1344)

* fix: make author block font sizing more specific (#1343)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Adam Boro <adam@adamboro.com>
Co-authored-by: Laurel <laurel.fulford@automattic.com>
Co-authored-by: matticbot <sysops+ghmatticbot@automattic.com>
matticbot pushed a commit that referenced this pull request Jan 25, 2023
# [1.61.0-alpha.1](v1.60.1...v1.61.0-alpha.1) (2023-01-25)

### Bug Fixes

* **donate-stripe:** initialize Stripe only if element is visible ([#1344](#1344)) ([207bff7](207bff7))
* **HPB:** author query if CAP is unavailable ([#1336](#1336)) ([b3ad96f](b3ad96f))
* make author block font sizing more specific ([#1343](#1343)) ([a84034f](a84034f))
* make sure correct avatar is loaded when guests and users share IDs ([#1339](#1339)) ([ebab2eb](ebab2eb))

### Features

* **homepage-posts-block:** filter image sizes based on the maximum image width ([#1322](#1322)) ([6bed199](6bed199))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.61.0-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Jan 25, 2023
# [1.61.0](v1.60.1...v1.61.0) (2023-01-25)

### Bug Fixes

* **donate-stripe:** initialize Stripe only if element is visible ([#1344](#1344)) ([207bff7](207bff7))
* **HPB:** author query if CAP is unavailable ([#1336](#1336)) ([b3ad96f](b3ad96f))
* make author block font sizing more specific ([#1343](#1343)) ([a84034f](a84034f))
* make sure correct avatar is loaded when guests and users share IDs ([#1339](#1339)) ([ebab2eb](ebab2eb))

### Features

* **homepage-posts-block:** filter image sizes based on the maximum image width ([#1322](#1322)) ([6bed199](6bed199))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.61.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants