Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(homepage-posts): sortable post selection #1502

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

miguelpeixe
Copy link
Member

@miguelpeixe miguelpeixe commented Jul 26, 2023

All Submissions:

Changes proposed in this Pull Request:

Make post selection for Homepage Posts sortable using https://github.com/clauderic/react-sortable-hoc

homepage-posts-sortable.mov

How to test the changes in this Pull Request:

  1. While on the master branch, build a page using the Homepage Posts block with specific posts selection
  2. Check out this branch, edit the same page and confirm the selection is preserved
  3. Sort using the drag handle, save, refresh and confirm the order was preserved
  4. Delete and add new items and confirm it behaves as expected
  5. Add a new Homepage Posts block with specific posts selection and confirm it also works with a fresh block
  6. Visit the page and confirm the same order is also rendered
  7. Confirm the default component behavior is also preserved by adding a new Homepage Posts block and querying through authors and categories

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@miguelpeixe miguelpeixe self-assigned this Jul 26, 2023
@miguelpeixe miguelpeixe requested a review from a team as a code owner July 26, 2023 20:54
@yogeshbeniwal
Copy link

findDOMNode method used by https://github.com/clauderic/react-sortable-hoc is due for removal in a future major version of React.

@miguelpeixe
Copy link
Member Author

Thank you for the heads up, @yogeshbeniwal!

The library is also no longer actively maintained. It's a bummer, being such a lightweight straightforward solution. I'll revisit this PR soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants