Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ras-acc): update shipping details header #1775

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

laurelfulford
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

This teeny PR switches the Shipping Details header from h2 to h3, both to match the hierarchy level of the Billing Details header, but also so it picks up the spacing styles.

How to test the changes in this Pull Request:

  1. On epic/ras-acc, set up a product that requires shipping, assign it to a Checkout Button block, and run a checkout.
  2. When you hit the second screen, note the spacing between the Billing Details heading and info, and the Shipping Details heading and info:

image

  1. Apply this PR and run npm run build.
  2. Run the checkout again and confirm that the spacing looks the same:

image

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Copy link
Contributor

@chickenn00dle chickenn00dle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@laurelfulford
Copy link
Contributor Author

Thanks @chickenn00dle! 🙌

@laurelfulford laurelfulford merged commit 8f30e09 into epic/ras-acc Jun 20, 2024
9 checks passed
@laurelfulford laurelfulford deleted the fix/shipping-header-spacing branch June 20, 2024 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants