Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rename all homepage posts patterns to content loop patterns #2046

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

thomasguillot
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

Since #2000 we have renamed the block to "Content Loop". This PR makes sure the patterns are named correctly

Note: once merged we will need to update https://help.newspack.com/publishing-and-appearance/blocks/block-patterns/

How to test the changes in this Pull Request:

  1. Add a pattern to a page
  2. Check if it's called correctly: "Newspack Content Loop" and "Content Loop Pattern x"

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@thomasguillot thomasguillot self-assigned this Feb 7, 2025
@thomasguillot thomasguillot requested a review from a team as a code owner February 7, 2025 14:47
Copy link
Contributor

@laurelfulford laurelfulford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, @thomasguillot!

I'm going to go ahead and merge this to make sure it makes it into today's alphas 🙂

@laurelfulford laurelfulford merged commit 9b6bdee into trunk Feb 7, 2025
9 checks passed
@laurelfulford laurelfulford deleted the update/rename-content-loop-patterns branch February 7, 2025 16:57
Copy link

github-actions bot commented Feb 7, 2025

Hey @thomasguillot, good job getting this PR merged! 🎉

Now, the needs-changelog label has been added to it.

Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label.

If it does, please add an entry to our shared document, with screenshots and testing instructions if applicable, then remove the label.

Thank you! ❤️

matticbot pushed a commit that referenced this pull request Feb 7, 2025
# [4.6.0-alpha.1](v4.5.10...v4.6.0-alpha.1) (2025-02-07)

### Bug Fixes

* enforce the password strength on checkout ([#2037](#2037)) ([b9dcf03](b9dcf03))
* make sure membership gate refreshes after variation purchase ([#2044](#2044)) ([1555b0f](1555b0f))
* remove OneSignal script from the modal checkout ([#2029](#2029)) ([343ca5e](343ca5e))
* return no posts for authors without term ([#2033](#2033)) ([e331139](e331139))

### Features

* **homepage-articles:** rename block and reorganise settings ([#2000](#2000)) ([841de19](841de19))
* rename all homepage posts patterns to content loop patterns ([#2046](#2046)) ([9b6bdee](9b6bdee))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 4.6.0-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@laurelfulford
Copy link
Contributor

The name in the patterns doc was already updated, so I just updated the screenshots -- feel free to replace @thomasguillot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants