Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle no posts without crashing #547

Closed
wants to merge 1 commit into from
Closed

Conversation

deBhal
Copy link

@deBhal deBhal commented Jul 15, 2020

All Submissions:

Changes proposed in this Pull Request:

I was testing the Carousel on an atomic site and ran in a series of weird errors - a missing element that swiper expects to exist, a bunch of this referring to the class instead of the instance, and a couple of unsafe dereferences when there are no slides.

This still feels like it might be me doing something wrong, but I wanted to get these changes up to see if someone could explain why I'm seeing them, so a PR isn't quite right, but it's pretty close.

I'm seeing this on an ephemeral site where I'm uploading the synced-coblocks plugin manually, and in chrome.

Closes # .

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@adekbadek
Copy link
Member

Hi @deBhal , sorry for the wait. Could you please provide steps to reproduce the issue(s)? Also, no-posts-handling was improved in #731, maybe it resolves the issue.

@deBhal deBhal closed this May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants