Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PT Translation: improve Donate block translation #706

Merged
merged 2 commits into from
Feb 24, 2021
Merged

PT Translation: improve Donate block translation #706

merged 2 commits into from
Feb 24, 2021

Conversation

laurelfulford
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

This PR updates the Portuguese translation for the Donate block thank you message (""Your contribution is appreciated.") from "Sua contribuição é apreciada." to "A sua contribuição é fundamental." based on publisher feedback.

How to test the changes in this Pull Request:

  1. Apply the PR.
  2. Switch your site's language to Portuguese under WP Admin > Settings.
  3. Add a donate block to a page; confirm that the thank you message reads "A sua contribuição é fundamental." both in the editor and on the front-end.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

dkoo
dkoo approved these changes Feb 17, 2021
View reviewed changes
Copy link
Contributor

@dkoo dkoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Noting that the translation only applies to Portuguese Portuguese (pt_PT); all other Portuguese settings still show English.

@laurelfulford laurelfulford merged commit 93c9da5 into master Feb 24, 2021
@laurelfulford laurelfulford deleted the fix/pt_PT-donate-translation branch February 24, 2021 22:52
matticbot pushed a commit that referenced this pull request Feb 24, 2021
@semantic-release-bot
chore(release): 1.21.1-alpha.1 [skip ci]
0b2bd38 
## [1.21.1-alpha.1](v1.21.0...v1.21.1-alpha.1) (2021-02-24)

### Bug Fixes

* update donate thank you message in Portuguese ([#706](#706)) ([93c9da5](93c9da5))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.21.1-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Feb 25, 2021
@semantic-release-bot
chore(release): 1.21.1 [skip ci]
030d9f8 
## [1.21.1](v1.21.0...v1.21.1) (2021-02-25)

### Bug Fixes

* update donate thank you message in Portuguese ([#706](#706)) ([93c9da5](93c9da5))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.21.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkoo dkoo dkoo approved these changes

Assignees
No one assigned
Labels
released on @alpha released [Status] Approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@laurelfulford @matticbot @dkoo