Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: add missing Carousel block attribute #754

Merged
merged 2 commits into from
May 5, 2021

Conversation

adekbadek
Copy link
Member

All Submissions:

Changes proposed in this Pull Request:

#746 added a new attribute to the Carousel block, but it was not registered on the backend - this fixes that.

Ideally the block attributes should be defined in a single JSON file, so that's the next step.

How to test the changes in this Pull Request:

  1. On master, insert a Carousel block
  2. Observe a PHP error logged about missing 'imageFit' index
  3. Switch to this branch, observe that all is well now

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@adekbadek adekbadek merged commit 2fcbec4 into master May 5, 2021
@adekbadek adekbadek deleted the fix/carousel-imagefit-attr branch May 5, 2021 08:49
@adekbadek adekbadek mentioned this pull request May 5, 2021
matticbot pushed a commit that referenced this pull request May 5, 2021
## [1.25.1](v1.25.0...v1.25.1) (2021-05-05)

### Bug Fixes

* **carousel:** add missing block attribute ([#754](#754)) ([2fcbec4](2fcbec4))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.25.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants