fix: remove unneeded logic

If no campaign ID is present an error is thrown, so it's unnecessary to check later.
Automattic · Apr 23, 2020 · 57c8ec0 · 57c8ec0
1 parent 203d64b
commit 57c8ec0
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/includes/class-newspack-newsletters.php b/includes/class-newspack-newsletters.php
@@ -716,7 +716,7 @@ public static function retrieve_data( $id ) {
 				);
 			}
 			$mc                  = new Mailchimp( self::mailchimp_api_key() );
-			$campaign            = $mc_campaign_id ? self::validate_mailchimp_operation( $mc->get( "campaigns/$mc_campaign_id" ) ) : null;
+			$campaign            = self::validate_mailchimp_operation( $mc->get( "campaigns/$mc_campaign_id" ) );
 			$list_id             = $campaign && isset( $campaign['recipients']['list_id'] ) ? $campaign['recipients']['list_id'] : null;
 			$interest_categories = $list_id ? self::validate_mailchimp_operation( $mc->get( "lists/$list_id/interest-categories" ) ) : null;
 			if ( $interest_categories && count( $interest_categories['categories'] ) ) {