Merge pull request #75 from Automattic/fix/settings-link

fix: move settings menu item to newspack newsletters menu
Automattic · Apr 20, 2020 · f104b21 · f104b21
2 parents 4f91af5 + 0fd0ac2
commit f104b21
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/includes/class-newspack-newsletters-settings.php b/includes/class-newspack-newsletters-settings.php
@@ -1,6 +1,6 @@
 <?php
 /**
- * Newspack Newsletters Settubgs Page
+ * Newspack Newsletters Settings Page
  *
  * @package Newspack
  */
@@ -45,9 +45,10 @@ public static function get_settings_list() {
 	 * Add options page
 	 */
 	public static function add_plugin_page() {
-		add_options_page(
-			__( 'Newspack Newsletters Settings', 'newspack-newsletters' ),
-			__( 'Newspack Newsletters', 'newspack-newsletters' ),
+		add_submenu_page(
+			'edit.php?post_type=' . Newspack_Newsletters::NEWSPACK_NEWSLETTERS_CPT,
+			__( 'Newsletters Settings', 'newspack-newsletters' ),
+			__( 'Settings', 'newspack-newsletters' ),
 			'manage_options',
 			'newspack-newsletters-settings-admin',
 			[ __CLASS__, 'create_admin_page' ]
@@ -60,7 +61,7 @@ public static function add_plugin_page() {
 	public static function create_admin_page() {
 		?>
 		<div class="wrap">
-			<h1><?php esc_html_e( 'Newspack Newsletters Settings', 'newspack-newsletters' ); ?></h1>
+			<h1><?php esc_html_e( 'Newsletters Settings', 'newspack-newsletters' ); ?></h1>
 			<form method="post" action="options.php">
 			<?php
 				settings_fields( 'newspack_newsletters_options_group' );