fix: avoid double notice components #1703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## trunk #1703 +/- ##
=========================================
Coverage 20.38% 20.38%
Complexity 2664 2664
=========================================
Files 48 48
Lines 10619 10619
=========================================
Hits 2165 2165
Misses 8454 8454 ☔ View full report in Codecov by Sentry. |
laurelfulford
approved these changes
Nov 11, 2024
github-actions
bot
added
[Status] Approved
|
Hey @dkoo, good job getting this PR merged! 🎉 Now, the Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label. If it does, please add an entry to our shared document, with screenshots and testing instructions if applicable, then remove the label. Thank you! ❤️ |
matticbot
pushed a commit
that referenced
this pull request
Nov 11, 2024
# [3.4.0-alpha.5](v3.4.0-alpha.4...v3.4.0-alpha.5) (2024-11-11) ### Bug Fixes * avoid double notice components ([#1703](#1703)) ([b8e9130](b8e9130))
|
🎉 This PR is included in version 3.4.0-alpha.5 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
matticbot
pushed a commit
that referenced
this pull request
Nov 11, 2024
# [3.4.0](v3.3.3...v3.4.0) (2024-11-11) ### Bug Fixes * avoid double notice components ([#1703](#1703)) ([b8e9130](b8e9130)) * avoid race condition between post-save sync & test ([#1679](#1679)) ([7bde119](7bde119)) * avoid Redux usage and related errors in non-newsletter email editors ([#1688](#1688)) ([d3f1f37](d3f1f37)) * correct button stacking on sent newsletters ([#1695](#1695)) ([4e2688e](4e2688e)) * dont html encode ampersands in subject ([#1686](#1686)) ([f178b23](f178b23)) * **mailchimp:** avoid duplicate audiences in Mailchimp UIs ([#1685](#1685)) ([44c1b12](44c1b12)) * move Preview, Send buttons to match Publish button location ([#1689](#1689)) ([72897f2](72897f2)) * preview & send buttons on WP 6.7 ([49450d3](49450d3)) * remove behavior to hide post title in newsletter editor ([#1701](#1701)) ([8a15cf5](8a15cf5)) ### Features * display list remote name on settings page ([#1672](#1672)) ([562d396](562d396))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
In WP 6.7 some
Noticecomponents are rendering twice if created viacreateNoticebut without anidprop. This adds theidprop to allcreateNoticecalls to avoid the duplicate renders.How to test the changes in this Pull Request:
trunk, using WP 6.7, edit a newsletter that's been sent already and observe that theCampaign sent on...message appears at the top of the editor screen twice.Other information: