fix: remove behavior to hide post title in newsletter editor

[dkoo]

All Submissions:

• Have you followed the Newspack Contributing guideline?
• Does your code follow the WordPress' coding standards and VIP Go coding standards?
• Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes proposed in this Pull Request:

This removes the behavior which attempts to hide the editor post title element in newsletter CPTs when the newsletter is NOT marked to be a "public post" after sending. The hiding behavior is inconsistent between WP 6.6 vs. WP 6.7 (it's actually been broken for while and few people noticed), and after some internal discussion we decided that the intended behavior that hides the core editor's title element in favor of the "Subject" field in the sidebar was potentially more confusing than helpful. This PR retains both the core post title element (keeping the UX more consistent with all other WP post editor screens) and sidebar subject field, which may be a little redundant but the most cautious approach to avoid disrupting editorial workflows.

Tagging @thomasguillot on this because I see some activity on this in some past threads, in case you want to revisit this UX.

How to test the changes in this Pull Request:

1. Edit a newsletter post and confirm that the post title is always visible at the top of the post editor screen, as with all other WP post editor screens. There should be no other functional changes.

Other information:

• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes, as applicable?
• Have you successfully ran tests with your changes locally?

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 20.38%. Comparing base (39e1aa5) to head (94b6c8f).
Report is 1 commits behind head on trunk.

Additional details and impacted files

@@            Coverage Diff            @@
##              trunk    #1701   +/-   ##
=========================================
  Coverage     20.38%   20.38%           
  Complexity     2664     2664           
=========================================
  Files            48       48           
  Lines         10619    10619           
=========================================
  Hits           2165     2165           
  Misses         8454     8454           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[leogermani]

just works

[github-actions]

Hey @dkoo, good job getting this PR merged! 🎉

Now, the needs-changelog label has been added to it.

Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label.

If it does, please add an entry to our shared document, with screenshots and testing instructions if applicable, then remove the label.

Thank you! ❤️

[matticbot]

🎉 This PR is included in version 3.4.0-alpha.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀