Add background color setting #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffersonrabb
approved these changes
Jun 12, 2020
There was a problem hiding this comment.
Looks good. Left one copy styling note then good to go.
This work raises two new questions, for separate PRs:
- The typography and background color should be saved with user defined layouts.
- Some of the group blocks in the default templates have solid white backgrounds. We should remove these so the page background is always visible.
| /> | ||
| <BaseControl label={ __( 'Background Color', 'newspack-newsletters' ) } id={ id }> |
There was a problem hiding this comment.
Suggested change
| <BaseControl label={ __( 'Background Color', 'newspack-newsletters' ) } id={ id }> | |
| <BaseControl label={ __( 'Background color', 'newspack-newsletters' ) } id={ id }> |
github-actions
bot
added
[Status] Approved
matticbot
pushed a commit
that referenced
this pull request
Jun 18, 2020
# [1.2.0](v1.1.0...v1.2.0) (2020-06-18) ### Bug Fixes * copy ([8fb1840](8fb1840)) * namespace use in register_rest_route ([ccaebbc](ccaebbc)) * raise list limit to maximum ([#224](#224)) ([863c8a7](863c8a7)) ### Features * remove white background from layouts' groups ([0fd4468](0fd4468)) * support background color setting ([2b98984](2b98984)), closes [#219](#219) * support background color setting ([#223](#223)) ([cb142eb](cb142eb)), closes [#219](#219) * **mjml:** reponsive images ([#222](#222)) ([c1867d9](c1867d9)), closes [#221](#221)
|
🎉 This PR is included in version 1.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Add setting for background color. During testing I've found that GMail and Outlook on iOS in dark mode disregard a white background color even if set, there's nothing we can do about it I think.
Closes #219.
How to test the changes in this Pull Request:
Other information: