Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: image height on smaller screens #222

Merged
merged 2 commits into from
Jun 15, 2020
Merged

Fix: image height on smaller screens #222

merged 2 commits into from
Jun 15, 2020

Conversation

adekbadek
Copy link
Member

All Submissions:

Changes proposed in this Pull Request:

On smaller screens, disregard explicit image height.

Closes #221

How to test the changes in this Pull Request:

  1. Create a newsletter with an image. Set the image dimensions, but keep the aspect ratio so it still looks ok.
  2. Send a test email and open it on GMail and Outlook apps on iOS device with a screen smaller than 590px (e.g. iPhone 8).
  3. Observe the image preserves aspect ratio (is not squished)

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@adekbadek
feat(mjml): reponsive images
c05b465 
on smaller screens, disregard explicit image height

Closes #221
@jeffersonrabb jeffersonrabb self-requested a review June 12, 2020 19:05
jeffersonrabb
jeffersonrabb approved these changes Jun 12, 2020
View reviewed changes
Copy link
Contributor

@jeffersonrabb jeffersonrabb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@adekbadek adekbadek merged commit c1867d9 into master Jun 15, 2020
@adekbadek adekbadek deleted the fix/responsive-images branch June 15, 2020 10:22
matticbot pushed a commit that referenced this pull request Jun 18, 2020
@semantic-release-bot
chore(release): 1.2.0 [skip ci]
99ba3e0 
# [1.2.0](v1.1.0...v1.2.0) (2020-06-18)

### Bug Fixes

* copy ([8fb1840](8fb1840))
* namespace use in register_rest_route ([ccaebbc](ccaebbc))
* raise list limit to maximum ([#224](#224)) ([863c8a7](863c8a7))

### Features

* remove white background from layouts' groups ([0fd4468](0fd4468))
* support background color setting ([2b98984](2b98984)), closes [#219](#219)
* support background color setting ([#223](#223)) ([cb142eb](cb142eb)), closes [#219](#219)
* **mjml:** reponsive images ([#222](#222)) ([c1867d9](c1867d9)), closes [#221](#221)
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffersonrabb jeffersonrabb jeffersonrabb approved these changes

Assignees
No one assigned
Labels
released [Status] Approved Ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Images squished on smaller screen sizes
3 participants
@adekbadek @matticbot @jeffersonrabb