Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Unsupported Features From Core Blocks #11

Merged
merged 4 commits into from
Apr 13, 2020
Merged

Remove Unsupported Features From Core Blocks #11

merged 4 commits into from
Apr 13, 2020

Conversation

jeffersonrabb
Copy link
Contributor

@jeffersonrabb jeffersonrabb commented Apr 12, 2020 •
edited
Loading

All Submissions:

Changes proposed in this Pull Request:

This removes some of the unsupported features from core blocks in non-hacky ways. We'll be able to remove some of the warnings in #9 after these changes are merged. Progress on WordPress/gutenberg#20588 will allow removal of other unsupported features, such as drop caps.

List of unsupported features and their status:

  • Nested columns. Notes: Given how essential columns are I'm wondering if we might need to use block filters to replace the column block edit component.
  • Vertical alignment in columns.
  • Social Links, "Logos Only" and "Pills" styles.
  • Separator, "Dots" style.
  • Buttons, gradient background.
  • Paragraph, inline image.
  • Paragraph, Drop Caps. Note: possible resolution in Block editor: Controlling the Block Editor WordPress/gutenberg#20588.
  • Columns, wide and full alignments.
  • Buttons left/right alignment.
  • Image left/right alignment. Note: Possible resolution in Block Alignments Rethinking WordPress/gutenberg#20650.
  • Paragraph left/right alignment.
  • Social LInks left/right alignment.

How to test the changes in this Pull Request:

  1. In a Newsletter add Social Icons add Separator, Social Links, Paragraph and Buttons blocks.
  2. Observe that none have any alignment options.
  3. Observe that Separator no longer has the "dots" style.
  4. Observe that Social Links no longer has Logos Only and Pills Shape styles.
  5. Observe Button color pickers no longer have gradient options.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@jeffersonrabb jeffersonrabb requested a review from adekbadek April 12, 2020 16:42
@jeffersonrabb jeffersonrabb self-assigned this Apr 12, 2020
@jeffersonrabb jeffersonrabb mentioned this pull request Apr 12, 2020
Merged
6 tasks
adekbadek
adekbadek approved these changes Apr 13, 2020
View reviewed changes
Copy link
Member

@adekbadek adekbadek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected! A much cleaner solution than warnings ;)

includes/class-newspack-newsletters-renderer.php Show resolved Hide resolved
@jeffersonrabb
feat: remove unsupported features of core blocks
69a0f10 
- Unregister unsupported block styles in Separator and Social Icons blocks.
- Remove alignment options (from all but Image).
- Alphabetize imports.
@jeffersonrabb
feat: disable gradients for the Newsletter custom post type
742e141
@jeffersonrabb
chore: remove completed TODO comments
5ccbd08
@jeffersonrabb
feat: disable column alignment
a16876e
@jeffersonrabb jeffersonrabb force-pushed the add/core-block-filtering branch from 30b74de to a16876e Compare April 13, 2020 11:45
@jeffersonrabb jeffersonrabb merged commit 2184d1f into master Apr 13, 2020
@jeffersonrabb jeffersonrabb added [Status] Approved Ready to merge and removed [Status] Approved Ready to merge labels Apr 13, 2020
adekbadek added a commit that referenced this pull request Apr 13, 2020
@adekbadek
feat: remove unnecessary warnings
6f32c04 
Some features were disabled in #11
@adekbadek adekbadek deleted the add/core-block-filtering branch April 22, 2020 14:27
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.0.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adekbadek adekbadek adekbadek approved these changes

Assignees

@jeffersonrabb jeffersonrabb

Labels
released on @alpha released [Status] Approved Ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeffersonrabb @matticbot @adekbadek