fix: preview & send buttons on WP 6.7

[adekbadek]

All Submissions:

• Have you followed the Newspack Contributing guideline?
• Does your code follow the WordPress' coding standards and VIP Go coding standards?
• Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes proposed in this Pull Request:

WP 6.7 updates some styling, which breaks our custom buttons:

6.6	6.7

This PR fixes that, while ensuring compatibility with 6.6.

How to test the changes in this Pull Request:

1. On trunk, switch WP to 6.7 (wp core update --version=6.7-beta3)
2. Open a newsletter or create a new on, observe broken UI
3. Switch to this branch, observe UI is now fine

Other information:

• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes, as applicable?
• Have you successfully ran tests with your changes locally?

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 20.30%. Comparing base (57d83fc) to head (ffb9971).

Additional details and impacted files

@@            Coverage Diff            @@
##              trunk    #1681   +/-   ##
=========================================
  Coverage     20.30%   20.30%           
  Complexity     2663     2663           
=========================================
  Files            48       48           
  Lines         10616    10616           
=========================================
  Hits           2156     2156           
  Misses         8460     8460           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[laurelfulford]

Such a good find, @adekbadek! 🙌

The buttons definitely look better.

One additional thing I noticed is that the buttons have also been reordered for posts and pages in WP 6.7, so they appear at the end:

Do you see any issues with doing the same for Newsletters? If we did, we'd probably want to do it a little closer to the actual WP 6.7 release (so the change drops around the same time); if it sounds like an okay move I can spin up a separate issue for it.

Thanks!

[adekbadek]

if it sounds like an okay move I can spin up a separate issue for it.

Please do, thanks! :)

[matticbot]

🎉 This PR is included in version 3.4.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀