Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mailchimp): fatal error with invalid API keys #1690

Merged
merged 9 commits into from
Nov 11, 2024

fix: avoid PHP deprecated warning

017efcc
Select commit
Loading
Failed to load commit list.
Merged

fix(mailchimp): fatal error with invalid API keys #1690

fix: avoid PHP deprecated warning
017efcc
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 11, 2024 in 1s

20.35% (-0.04%) compared to 44c1b12

View this Pull Request on Codecov

20.35% (-0.04%) compared to 44c1b12

Details

Codecov Report

Attention: Patch coverage is 4.00000% with 24 lines in your changes missing coverage. Please review.

Project coverage is 20.35%. Comparing base (44c1b12) to head (017efcc).
Report is 28 commits behind head on trunk.

Files with missing lines Patch % Lines
...ass-newspack-newsletters-mailchimp-cached-data.php 4.54% 21 Missing ⚠️
includes/class-newspack-newsletters-settings.php 0.00% 2 Missing ⚠️
...mailchimp/class-newspack-newsletters-mailchimp.php 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##              trunk    #1690      +/-   ##
============================================
- Coverage     20.38%   20.35%   -0.04%     
- Complexity     2664     2670       +6     
============================================
  Files            48       48              
  Lines         10619    10640      +21     
============================================
+ Hits           2165     2166       +1     
- Misses         8454     8474      +20

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov