-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: rate limit requests for CC #1714
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## trunk #1714 +/- ##
============================================
+ Coverage 23.00% 23.07% +0.07%
- Complexity 2710 2713 +3
============================================
Files 49 49
Lines 10751 10761 +10
============================================
+ Hits 2473 2483 +10
Misses 8278 8278 ☔ View full report in Codecov by Sentry. |
Hey @leogermani, good job getting this PR merged! 🎉 Now, the Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label. If it does, please add an entry to our shared document, with screenshots and testing instructions if applicable, then remove the label. Thank you! ❤️ |
# [3.6.0-alpha.1](v3.5.0...v3.6.0-alpha.1) (2024-11-29) ### Bug Fixes * let the exceptions be thrown ([#1698](#1698)) ([85746b8](85746b8)) ### Features * **ras-acc:** add reader account creation and login improvements ([#1716](#1716)) ([4640cae](4640cae)) * rate limit requests for CC ([#1714](#1714)) ([ad092ca](ad092ca))
🎉 This PR is included in version 3.6.0-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
# [3.6.0](v3.5.0...v3.6.0) (2024-12-09) ### Bug Fixes * let the exceptions be thrown ([#1698](#1698)) ([85746b8](85746b8)) ### Features * **ras-acc:** add reader account creation and login improvements ([#1716](#1716)) ([4640cae](4640cae)) * rate limit requests for CC ([#1714](#1714)) ([ad092ca](ad092ca))
🎉 This PR is included in version 3.6.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
All Submissions:
Changes proposed in this Pull Request:
Adds a rate limit for Constant Contact request. It should not make more than 4 requests per second.
How to test the changes in this Pull Request:
1.Smoke test a Constant Contact connection
Other information: