Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: apply custom styles even if styling tab in sidebar is closed #240

Merged
merged 2 commits into from
Jun 26, 2020
Merged

Fix: apply custom styles even if styling tab in sidebar is closed #240

merged 2 commits into from
Jun 26, 2020

Conversation

adekbadek
Copy link
Member

All Submissions:

Changes proposed in this Pull Request:

Fixes a subtle bug, see below

How to test the changes in this Pull Request:

  1. On master
  2. Create a newsletter, apply custom styling in the Styling panel in Sidebar, close the panel and refresh the page
  3. Observe that the custom styling is not applied until the Styling panel is opened
  4. Switch to this branch, rebuild
  5. Redo step 2, refresh the page – observe that the custom styling is applied

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@adekbadek adekbadek requested a review from jeffersonrabb June 26, 2020 09:46
jeffersonrabb
jeffersonrabb approved these changes Jun 26, 2020
View reviewed changes
Copy link
Contributor

@jeffersonrabb jeffersonrabb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fix.

@adekbadek adekbadek merged commit 20b08bc into master Jun 26, 2020
@adekbadek adekbadek deleted the fix/styles-application branch June 26, 2020 12:58
matticbot pushed a commit that referenced this pull request Jun 30, 2020
@semantic-release-bot
chore(release): 1.3.0 [skip ci]
0066a55 
# [1.3.0](v1.2.0...v1.3.0) (2020-06-30)

### Bug Fixes

* apply custom styles even if styling tab in sidebar is closed ([#240](#240)) ([20b08bc](20b08bc))
* localize date formats and notice text ([0cb82f1](0cb82f1))
* posts-inserter columns warning ([5db6b97](5db6b97))
* store translated success note as prop ([5638aee](5638aee))

### Features

* add "sent" status to posts list in dashboard ([ed369e4](ed369e4))
* add a "sent" editor notice after a campaign has been sent ([188908e](188908e))
* column middle alignment handling ([5f82db4](5f82db4)), closes [#231](#231)
* handle custom styling of layouts ([#238](#238)) ([2ba844d](2ba844d)), closes [#225](#225)
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffersonrabb jeffersonrabb jeffersonrabb approved these changes

Assignees
No one assigned
Labels
released [Status] Approved Ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adekbadek @matticbot @jeffersonrabb