Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix custom colors on buttons #301

Merged
merged 2 commits into from
Aug 19, 2020
Merged

Fix custom colors on buttons #301

merged 2 commits into from
Aug 19, 2020

Conversation

adekbadek
Copy link
Member

All Submissions:

Changes proposed in this Pull Request:

Closes #229.

How to test the changes in this Pull Request:

  1. On master, create a newsletter with buttons. Set colors on them – custom and picked from color palette
  2. Send a test email or preview the email, observe the custom colors are lost
  3. Switch to this branch, send or preview again, observe colors are all there

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@adekbadek adekbadek merged commit 8ebcf5d into master Aug 19, 2020
@adekbadek adekbadek deleted the fix/button-colors branch August 19, 2020 14:07
matticbot pushed a commit that referenced this pull request Aug 20, 2020
# [1.9.0-alpha.1](v1.8.1...v1.9.0-alpha.1) (2020-08-20)

### Bug Fixes

* button custom colors ([#301](#301)) ([8ebcf5d](8ebcf5d))
* first time set up flow ([c16d6bf](c16d6bf))
* pre-send info if no list set ([#297](#297)) ([f575d94](f575d94))

### Features

* enable public newsletter posts ([#272](#272)) ([ef90bf9](ef90bf9))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.9.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Aug 20, 2020
# [1.9.0](v1.8.1...v1.9.0) (2020-08-20)

### Bug Fixes

* button custom colors ([#301](#301)) ([8ebcf5d](8ebcf5d))
* first time set up flow ([c16d6bf](c16d6bf))
* pre-send info if no list set ([#297](#297)) ([f575d94](f575d94))

### Features

* enable public newsletter posts ([#272](#272)) ([ef90bf9](ef90bf9))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.9.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Button Colors Lost In Emails
3 participants