fix: crashes with autocomplete inputs in Campaigns wizard and Categor…

…yAutocomplete (#1609)

* fix: crashes with autocomplete inputs in Campaigns wizard and CategoryAutocomplete

* refactor: easier-to-read token array filtering

* refactor: filter on the component, not the prop

assets/components/src/category-autocomplete/index.js

@@ -96,17 +96,20 @@ class CategoryAutocomplete extends Component {
 		const { suggestions } = this.state;
 		// Categories that are already will be objects, while new additions will be strings (the name).
 		// allValues nomalizes the array so that they are all objects.
-		const allValues = tokens.map( token =>
-			typeof token === 'string' ? suggestions[ token ] : token
-		);
+		const allValues = tokens
+			.filter( token => 'undefined' !== typeof token ) // Ensure each token is a valid value.
+			.map( token => ( 'string' === typeof token ? suggestions[ token ] : token ) )
+			.filter( Boolean );
 		onChange( allValues );
 	};
 
 	getAvailableSuggestions = () => {
 		const { value } = this.props;
 		const { suggestions } = this.state;
 		const selectedIds = value.reduce( ( acc, item ) => {
-			acc.push( item.id );
+			if ( item?.id ) {
+				acc.push( item.id );
+			}
 			return acc;
 		}, [] );
 		const availableSuggestions = filter(

assets/wizards/popups/components/settings-modal/index.js

@@ -177,7 +177,9 @@ const PromptSettingsModal = ( { prompt, disabled, onClose, segments, updatePopup
 								value={ excludedCategories || [] }
 								onChange={ tokens =>
 									setPromptConfig( {
-										options: { excluded_categories: tokens.map( token => token.id ) },
+										options: {
+											excluded_categories: tokens.map( token => token.id ),
+										},
 									} )
 								}
 								description={ __(
@@ -191,7 +193,13 @@ const PromptSettingsModal = ( { prompt, disabled, onClose, segments, updatePopup
 								hideHelpFromVision
 								taxonomy="tags"
 								value={ excludedTags || [] }
-								onChange={ tokens => setPromptConfig( { options: { excluded_tags: tokens } } ) }
+								onChange={ tokens =>
+									setPromptConfig( {
+										options: {
+											excluded_tags: tokens.map( token => token.id ),
+										},
+									} )
+								}
 								description={ __(
 									'Prompt will not appear on posts with the specified tags.',
 									'newspack'