-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(site-kit): add logging when site kit disconnects #3472
Conversation
fc03623
to
b948ebf
Compare
b948ebf
to
856f034
Compare
3e50ac4
to
023544e
Compare
fc6877b
to
81e290e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful.
I did a small change to bum the log level for the cron check so we can get more proactive alerts
# [5.7.0-alpha.1](v5.6.0...v5.7.0-alpha.1) (2024-11-06) ### Bug Fixes * avoid duplicate info notices in email editors ([#3512](#3512)) ([d38fc1a](d38fc1a)) * **co-authors-plus:** CLI for migrating from CAP GA ([9a81584](9a81584)) * command to fix active subs w/ missing next_payment dates ([#3484](#3484)) ([2e05fd4](2e05fd4)) * php fatal and warning ([#3502](#3502)) ([e089172](e089172)) * **site-kit:** update logger cron to hourly interval ([#3485](#3485)) ([e3823e7](e3823e7)) * **webhooks:** deprecate global endpoint ([#3492](#3492)) ([63e8ab2](63e8ab2)) * **wp-6.7:** update radio control styles ([#3518](#3518)) ([831756e](831756e)) ### Features * add user name to woocommerce data events ([#3473](#3473)) ([5312d30](5312d30)) * automatically disable guest authors ([#3345](#3345)) ([d0db6ba](d0db6ba)) * **connections:** jetpack sso ([#3486](#3486)) ([123408e](123408e)) * display list remote name on newsletter wizard ([#3478](#3478)) ([cd0b859](cd0b859)) * **site-kit:** add logging when site kit disconnects ([#3472](#3472)) ([62bf98c](62bf98c))
🎉 This PR is included in version 5.7.0-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
# [5.7.0](v5.6.1...v5.7.0) (2024-11-11) ### Bug Fixes * avoid duplicate info notices in email editors ([#3512](#3512)) ([d38fc1a](d38fc1a)) * **co-authors-plus:** CLI for migrating from CAP GA ([9a81584](9a81584)) * command to fix active subs w/ missing next_payment dates ([#3484](#3484)) ([2e05fd4](2e05fd4)) * php fatal and warning ([#3502](#3502)) ([e089172](e089172)) * **site-kit:** update logger cron to hourly interval ([#3485](#3485)) ([e3823e7](e3823e7)) * **webhooks:** deprecate global endpoint ([#3492](#3492)) ([63e8ab2](63e8ab2)) * **wp-6.7:** update radio control styles ([#3518](#3518)) ([831756e](831756e)) ### Features * add user name to woocommerce data events ([#3473](#3473)) ([5312d30](5312d30)) * automatically disable guest authors ([#3345](#3345)) ([d0db6ba](d0db6ba)) * **connections:** jetpack sso ([#3486](#3486)) ([123408e](123408e)) * display list remote name on newsletter wizard ([#3478](#3478)) ([cd0b859](cd0b859)) * **site-kit:** add logging when site kit disconnects ([#3472](#3472)) ([62bf98c](62bf98c))
🎉 This PR is included in version 5.7.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
All Submissions:
Changes proposed in this Pull Request:
Closes https://app.asana.com/0/1206274567818686/1207849727795693
This PR adds newspack manager logging whenever we detect a site kit disconnection via:
delete_option_{option}
hook for thehas_connected_admin
option.update_user_metadata
hook for when thedisconnected_reason
user meta is updated.For the first two cases, a backtrace is included in the log. For the final one, we simply log a message.
How to test the changes in this Pull Request:
newspack_googlesitekit_disconnection_logger
cron event is present./tmp/
like/tmp/2024-XX-XX-newspack_googlesitekit_disconnect
No active Google Site Kit connections found
Google Site Kit has been disconnected for all admins
Google Site Kit has been disconnected with reason REASON
Other information: