Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(connections): jetpack sso settings wizard #3524

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

miguelpeixe
Copy link
Member

All Submissions:

Changes proposed in this Pull Request:

Implements #3486 to the IA project.

image image

How to test the changes in this Pull Request:

  1. Make sure you have Jetpack active and a newspack manager client instance connected to your site
  2. Navigate to Newspack -> Settings -> Connections and scroll down to "Jetpack SSO"
  3. Confirm it renders as in the first image above
  4. Toggle it and confirm the action card updates with the default settings, as in the second image above
  5. Switch to "Emails" then back to "Connections" and confirm the options persist
  6. Refresh the page and confirm the options persist
  7. Change the capability, toggle the "obfuscate" option, and save
  8. Refresh the page and confirm the new options persist

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@miguelpeixe miguelpeixe added the [Status] Needs Review The issue or pull request needs to be reviewed label Nov 5, 2024
@miguelpeixe miguelpeixe self-assigned this Nov 5, 2024
@miguelpeixe miguelpeixe requested a review from a team as a code owner November 5, 2024 15:43
@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Nov 19, 2024
@leogermani leogermani merged commit 3ef3e83 into epic/ia Nov 19, 2024
9 checks passed
@leogermani leogermani deleted the feat/ia-connections-jetpack-sso branch November 19, 2024 16:55
@leogermani
Copy link
Contributor

Works as described!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants