fix: prevent PHP warning when previewing prompts

Automattic · Feb 16, 2023 · 5a85939 · 5a85939
1 parent 6fde157
commit 5a85939
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/api/campaigns/class-maybe-show-campaign.php b/api/campaigns/class-maybe-show-campaign.php
@@ -272,7 +272,7 @@ public function should_popup_be_shown( $client_id, $popup, $settings, $referer_u
 					$should_display = true;
 				}
 			}
-		} elseif ( $should_display && ! empty( $popup_segment_ids ) ) {
+		} elseif ( $should_display && ! empty( $popup_segment_ids ) && ! empty( $settings ) ) {
 			// $settings->best_priority_segment_id should always be present, but in case it's not (e.g. in a unit test), we can fetch it here.
 			$best_priority_segment_id = isset( $settings->best_priority_segment_id ) ?
 				$settings->best_priority_segment_id :