Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focus trap in overlay campaigns #24

Open
4 of 5 tasks
jeffersonrabb opened this issue Dec 2, 2019 · 5 comments · May be fixed by #298
Open
4 of 5 tasks

Focus trap in overlay campaigns #24

jeffersonrabb opened this issue Dec 2, 2019 · 5 comments · May be fixed by #298

Comments

@jeffersonrabb
Copy link
Contributor

jeffersonrabb commented Dec 2, 2019

@jeffersonrabb
Copy link
Contributor Author

@thomasguillot could you jot down your findings on the a11y aspects of this plugin, for posterity?

@thomasguillot
Copy link
Contributor

When the pop-up is visible. The keyboard navigation should only loop within the pop-up, until the dismiss (or submit...) button is clicked.

@thomasguillot
Copy link
Contributor

The timed pop-up should be displayed after the header but before the content.

@adekbadek adekbadek linked a pull request Nov 3, 2020 that will close this issue
6 tasks
@adekbadek adekbadek changed the title Launch TODOs Focus trap in overlay campaigns Nov 3, 2020
@adekbadek adekbadek added the A11y label Nov 3, 2020
@adekbadek
Copy link
Member

It looks like amp-lightbox component does not trap focus, so this can only be achieved in a non-AMP way.

For that, the focus-trap library can be used. Here's a POC: #298

@dkoo
Copy link
Contributor

dkoo commented Feb 7, 2022

This hasn't changed according to recent AMP activity. I think we should put this issue on hold until we can replace amp-access with a unified way to check whether a prompt should be displayed (e.g. Bento).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants