Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support For Non-AMP Requests #26

Merged
merged 1 commit into from
Dec 6, 2019
Merged

Conversation

jeffersonrabb
Copy link
Contributor

@jeffersonrabb jeffersonrabb commented Dec 6, 2019

All Submissions:

Changes proposed in this Pull Request:

This PR registers and enqueues the AMP scripts so that they will be loaded in non-AMP requests, even if the AMP plugin is not installed.

How to test the changes in this Pull Request:

  1. Create a Pop-Up, in an incognito window verify that it reveals and behaves normally in an AMP request.
  2. Switch AMP mode to Transitional, test that behavior is identical in AMP and non-AMP requests.
  3. Do the same in Reader Mode.
  4. Disable the AMP plugin, then re-test a page. It should behave just like the AMP version.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Copy link
Contributor

@claudiulodro claudiulodro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; works good. 👍

@jeffersonrabb jeffersonrabb merged commit 5220edc into master Dec 6, 2019
@jeffersonrabb jeffersonrabb deleted the add/non-amp-support branch December 6, 2019 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants