Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: polyfill amp-access script #959

Merged
merged 1 commit into from
Sep 14, 2022
Merged

Conversation

adekbadek
Copy link
Member

@adekbadek adekbadek commented Sep 9, 2022

All Submissions:

Changes proposed in this Pull Request:

Closes #193
Closes #880
Closes #749
Closes #170
Closes #569

How to test the changes in this Pull Request:

  1. Set up a site with a few prompts
  2. Test without AMP
  3. Observe the appropriate prompts hidden and displayed, according to the segmentation and view logic
  4. Observe that the AMP runtime JS files are not loaded
  5. Observe that Conflict with wpDiscuz #880, Conflict with Liveblog plugin #749, Campaigns + Jetpack Slideshow + No AMP = No slideshow in Chrome #170, and Campaigns + no AMP cause Web Stories block not to work #569 are not reproducible anymore

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Copy link
Contributor

@dkoo dkoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been a long time coming and the changeset is much smaller than I would have expected. Very nicely done!

@matticbot
Copy link
Contributor

🎉 This PR is included in version 2.6.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@matticbot
Copy link
Contributor

🎉 This PR is included in version 2.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment