fix: make pullquote citations inherit correct color (#1116)

Automattic · Oct 20, 2020 · f537fd6 · f537fd6
1 parent e383eb9
commit f537fd6
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 6 deletions.
diff --git a/newspack-katharine/sass/style.scss b/newspack-katharine/sass/style.scss
@@ -283,10 +283,6 @@ figcaption,
 		}
 	}
 
-	cite {
-		color: $color__text-light;
-	}
-
 	cite,
 	&.is-style-solid-color blockquote cite {
 		text-transform: uppercase;

diff --git a/newspack-theme/sass/blocks/_blocks.scss b/newspack-theme/sass/blocks/_blocks.scss
@@ -335,10 +335,12 @@
 
 	cite {
 		display: inline-block;
+		color: inherit;
 		font-family: $font__heading;
+		font-size: $font__size-xs;
+		opacity: 0.8;
 		line-height: 1.6;
 		text-transform: none;
-		font-size: $font__size-xs;
 
 		&::before {
 			content: '\2014';

diff --git a/newspack-theme/sass/style-editor-base.scss b/newspack-theme/sass/style-editor-base.scss
@@ -245,7 +245,8 @@ figcaption,
 	.entry-meta a,
 	.entry-meta a:visited,
 	.entry-meta .byline a,
-	.entry-meta .byline a:visited {
+	.entry-meta .byline a:visited,
+	cite {
 		color: inherit;
 	}
 
@@ -500,6 +501,10 @@ figcaption,
 		}
 	}
 
+	div.wp-block-pullquote__citation {
+		opacity: 0.8;
+	}
+
 	em {
 		font-style: normal;
 	}
-Original file line number
+Diff line change
@@ Expand Up / @@ -283,10 +283,6 @@ figcaption, @@
     		}
     	}
-    	cite {
-    		color: $color__text-light;
-    	}
     	cite,
     	&.is-style-solid-color blockquote cite {
     		text-transform: uppercase;
@@ Expand Down @@