Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block Widgets: Correct font previews #1401

Merged
merged 1 commit into from
Jul 5, 2021
Merged

Block Widgets: Correct font previews #1401

merged 1 commit into from
Jul 5, 2021

Conversation

laurelfulford
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

This PR updates some of the custom typography selectors, to make sure the blocks are picking them up on the Widgets screen.

Closes #1394

How to test the changes in this Pull Request:

  1. Start with a test site running the latest WP 5.8 release candidate.
  2. In the Customizer, set a custom header and body font.
  3. Navigate to WP Admin > Appearance > Widgets; add a Homepage Posts block, Heading block, Author block and Post Carousel block.
  4. Note that all but the Homepage Posts block aren't picking up your custom header font. In this case, the headers should be Montserrat (like the Homepage Posts block), but many are picking up the child theme's Fira Sans Condensed:

image

  1. Apply the PR.
  2. Refresh the page; confirm that the blocks are now picking up your custom fonts:

image

  1. Test the same blocks in the post/page editor and confirm that they're still using your custom header fonts.
  2. Test on a site running 5.7, and add the same blocks to the post/page editor and confirm that they're still using your custom header fonts.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@laurelfulford laurelfulford added the [Status] Needs Review The issue or pull request needs to be reviewed label Jul 2, 2021
@laurelfulford laurelfulford requested a review from a team July 2, 2021 23:40
@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Jul 5, 2021
@laurelfulford
Copy link
Contributor Author

Thanks @adekbadek!

@laurelfulford laurelfulford merged commit 878b6a1 into master Jul 5, 2021
matticbot pushed a commit that referenced this pull request Jul 6, 2021
@semantic-release-bot
chore(release): 1.39.3-alpha.1 [skip ci]
be3aec9 
## [1.39.3-alpha.1](v1.39.2...v1.39.3-alpha.1) (2021-07-06)

### Bug Fixes

* ads media queries ([239ff6e](239ff6e))
* correct custom fonts in block widget preview ([#1401](#1401)) ([878b6a1](878b6a1))
* figcaption rendering bug in Safari ([#1382](#1382)) ([e274499](e274499))
* improve donate block appearance for WP 5.8 ([#1398](#1398)) ([51fc4f7](51fc4f7))
* prevent white screen and errors on Widget Screen ([#1390](#1390)) ([5731581](5731581))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.39.3-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Jul 6, 2021
@semantic-release-bot
chore(release): 1.39.3 [skip ci]
b6f7a7a 
## [1.39.3](v1.39.2...v1.39.3) (2021-07-06)

### Bug Fixes

* ads media queries ([239ff6e](239ff6e))
* correct custom fonts in block widget preview ([#1401](#1401)) ([878b6a1](878b6a1))
* figcaption rendering bug in Safari ([#1382](#1382)) ([e274499](e274499))
* improve donate block appearance for WP 5.8 ([#1398](#1398)) ([51fc4f7](51fc4f7))
* prevent white screen and errors on Widget Screen ([#1390](#1390)) ([5731581](5731581))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.39.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adekbadek adekbadek adekbadek approved these changes

Assignees
No one assigned
Labels
released on @alpha released [Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Widgets Screen: Custom Fonts not being applied
3 participants
@laurelfulford @matticbot @adekbadek