Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dequeue FSE global styles #1724

Merged
merged 4 commits into from
Mar 10, 2022
Merged

Dequeue FSE global styles #1724

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8f33bd4
fix: dequeue Gutenberg's global styles
laurelfulford Mar 4, 2022
49360a9
fix: adding links to relevant WordPress docs
laurelfulford Mar 4, 2022
e938037
fix: clean up unneeded spaces
laurelfulford Mar 4, 2022
38c61af
fix: remove priority from stylesheet dequeue
laurelfulford Mar 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions newspack-theme/functions.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -597,6 +597,31 @@ function newspack_enqueue_scripts() {
}
add_action( 'enqueue_block_editor_assets', 'newspack_enqueue_scripts' );

/**
* Dequeue Gutenberg global styles.
*
* These styles aren't currently used because Newspack is not a Full-Site editing theme.
*
* @link: https://developer.wordpress.org/reference/functions/wp_enqueue_global_styles/
*/
function newspack_dequeue_global_styles() {
wp_dequeue_style( 'global-styles' );
}
add_action( 'wp_enqueue_scripts', 'newspack_dequeue_global_styles' );

/**
* Dequeue Gutenberg global editor styles.
*
* These styles aren't currently used because Newspack is not a Full-Site editing theme.
*
* @link: https://developer.wordpress.org/reference/functions/wp_enqueue_global_styles_css_custom_properties/
*/
function newspack_dequeue_global_editor_styles() {
wp_dequeue_style( 'global-styles-css-custom-properties' );
}
add_action( 'enqueue_block_editor_assets', 'newspack_dequeue_global_editor_styles' );


/**
* Fix skip link focus in IE11.
*
Expand Down
6 changes: 4 additions & 2 deletions newspack-theme/sass/blocks/_blocks.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1306,7 +1306,8 @@ hr {
font-size: $font__size-lg;
}

.has-huge-font-size {
.has-huge-font-size,
.has-x-large-font-size {
font-size: $font__size-xl;
}

Expand All @@ -1315,7 +1316,8 @@ hr {
font-size: $font__size-xl;
}

.has-huge-font-size {
.has-huge-font-size,
.has-x-large-font-size {
font-size: $font__size-xxl;
}
}
Expand Down