Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Bluesky to the profile fields #2413

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

leogermani
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

Adds the Bluesky profile field.

Note. There's also another filter in Yoast that I was trying, that looks like it has to do with it, but I don't see it having any effect, so I removed it. It's this:

add_filter(
'wpseo_person_social_profile_fields',
function( $profile_fields ) {
	if ( ! array_key_exists( 'bluesky', $profile_fields ) ) {
		$profile_fields['bluesky'] = 'get_non_valid_url';
	}
	return $profile_fields;
}
);

How to test the changes in this Pull Request:

  1. Edit an author profie
  2. Confirm you see a new field for Bluesky profile
  3. Add a url starting with https://bsky.app/profile/
  4. Visit the author archive page
  5. Confirm you see the Bluesky link with the correct icon

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@leogermani leogermani added the [Status] Needs Review The issue or pull request needs to be reviewed label Nov 20, 2024
@leogermani leogermani self-assigned this Nov 20, 2024
@leogermani leogermani requested a review from a team as a code owner November 20, 2024 13:01
Copy link
Contributor

@dkoo dkoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't working for me. 😕 Doing some light debugging, it looks like the wpseo_additional_contactmethods filter hook isn't getting called on my site. I have Yoast active and a BlueSky profile URL in my author's profile.

@leogermani
Copy link
Contributor Author

This isn't working for me. 😕 Doing some light debugging, it looks like the wpseo_additional_contactmethods filter hook isn't getting called on my site. I have Yoast active and a BlueSky profile URL in my author's profile.

If you are seeing the bluesky input in the "edit user" page it means the hook is working fine.

Have you enabled social icons for authors in the theme? It's an option in the theme somewhere. I don't know where you turn this on in the UI (probably in the Customizer), but you can also do so by set_theme_mod( 'show_author_social', true );

@leogermani leogermani requested a review from dkoo November 21, 2024 18:03
@laurelfulford
Copy link
Contributor

laurelfulford commented Nov 21, 2024

I don't know where you turn this on in the UI (probably in the Customizer)

It's under Customizer > Author Bio Settings, "Display Author Social Media links" 🙂

Copy link
Contributor

@dkoo dkoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's under Customizer > Author Bio Settings, "Display Author Social Media links" 🙂

Yes, that's exactly what I was missing—sorry!

@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Nov 21, 2024
@leogermani leogermani merged commit 6651f67 into trunk Nov 21, 2024
6 checks passed
@leogermani leogermani deleted the feat/add-bluesky-social-user-profile branch November 21, 2024 19:04
Copy link

Hey @leogermani, good job getting this PR merged! 🎉

Now, the needs-changelog label has been added to it.

Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label.

If it does, please add an entry to our shared document, with screenshots and testing instructions if applicable, then remove the label.

Thank you! ❤️

matticbot pushed a commit that referenced this pull request Nov 21, 2024
# [2.3.0-alpha.3](v2.3.0-alpha.2...v2.3.0-alpha.3) (2024-11-21)

### Features

* add Bluesky to the profile fields ([#2413](#2413)) ([a4eb21b](a4eb21b))
* add Bluesky to the Social Links menu ([#2412](#2412)) ([e32f604](e32f604))
matticbot pushed a commit that referenced this pull request Nov 25, 2024
# [2.3.0](v2.2.1...v2.3.0) (2024-11-25)

### Bug Fixes

* make button background styles more specific ([#2407](#2407)) ([21f6a4e](21f6a4e))

### Features

* add Bluesky to the profile fields ([#2413](#2413)) ([a4eb21b](a4eb21b))
* add Bluesky to the Social Links menu ([#2412](#2412)) ([e32f604](e32f604))
* **author-archive:** replace twitter icon with x ([2f4709a](2f4709a))
matticbot pushed a commit that referenced this pull request Nov 29, 2024
# [2.4.0-alpha.1](v2.3.0...v2.4.0-alpha.1) (2024-11-29)

### Bug Fixes

* remove translation workaround; the issue is fixed in WP ([#2415](#2415)) ([da4efd9](da4efd9))

### Features

* add Bluesky to the profile fields ([#2413](#2413)) ([6651f67](6651f67))
* add Bluesky to the Social Links menu ([#2412](#2412)) ([16a33aa](16a33aa))
* merge RAS-ACC work into trunk ([#2417](#2417)) ([4488d59](4488d59))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 2.4.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Dec 9, 2024
# [2.4.0](v2.3.0...v2.4.0) (2024-12-09)

### Bug Fixes

* remove translation workaround; the issue is fixed in WP ([#2415](#2415)) ([da4efd9](da4efd9))

### Features

* add Bluesky to the profile fields ([#2413](#2413)) ([6651f67](6651f67))
* add Bluesky to the Social Links menu ([#2412](#2412)) ([16a33aa](16a33aa))
* merge RAS-ACC work into trunk ([#2417](#2417)) ([4488d59](4488d59))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 2.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released on @alpha released [Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants