Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPM 404 Redirect, failed 2.2.0 download link access #1316

Closed
hmmhmmhm opened this issue Dec 3, 2018 · 3 comments
Closed

NPM 404 Redirect, failed 2.2.0 download link access #1316

hmmhmmhm opened this issue Dec 3, 2018 · 3 comments

Comments

@hmmhmmhm
Copy link

hmmhmmhm commented Dec 3, 2018

Issue or Feature

2

1

3

Hello~

Although the canvas module is confirmed to have been updated,
It looks like a the download link does not appear to exist yet.

https://github.com/node-gfx/node-canvas-prebuilt/releases/

If the work is still in progress,
please fix release links, thanks

Steps to Reproduce

Just create new npm project,
and run npm install canvas command.

Your Environment

node 11.3 on Windows 10 x64

@chearon
Copy link
Collaborator

chearon commented Dec 3, 2018

Done

@LinusU any more thoughts on waiting on prebuilds in between tagging and releasing? We could make it build when a tag is pushed automatically too, though usually some manual intervention is needed because something like #1317 always happens, or I haven't yet updated the binding.gyp etc

@chearon chearon closed this as completed Dec 3, 2018
@LinusU
Copy link
Collaborator

LinusU commented Dec 4, 2018

@chearon sorry, haven't looked any more into that 🙈

Would love to have something automatic, but before that, I could start holding of pushing to npm?

Maybe we could even publish to a special tag, e.g. next, and then when the prebuilds are done we can point latest to that version as well?

@chearon
Copy link
Collaborator

chearon commented Dec 4, 2018

Would love to have something automatic, but before that, I could start holding of pushing to npm?

Yeah, once the (git) tag is pushed the binaries can be built, and after that you can safely release

Maybe we could even publish to a special tag, e.g. next, and then when the prebuilds are done we can point latest to that version as well?

Sure that works! That might be a little easier for you since you can just it once with NPM instead of having to do the git tag first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants