Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't build against node 7 #1317

Closed
chearon opened this issue Dec 3, 2018 · 2 comments
Closed

Doesn't build against node 7 #1317

chearon opened this issue Dec 3, 2018 · 2 comments
Labels

Comments

@chearon
Copy link
Collaborator

chearon commented Dec 3, 2018

Issue or Feature

Ran into this doing the prebuilds. 2.2.0 doesn't build in Node 7 on any of the 3 platforms. Node 6 does. Should we add all versions to the build matrix?

Steps to Reproduce

  • npm install in the repo
  • src/CanvasRenderingContext2d.cc:1722:49: error: no member named 'InstanceOf' in 'v8::Object'

Looks like it was caused by #1293 (this line). Should it be > 7 instead?

Your Environment

  • Version of node-canvas (output of npm list canvas or yarn list canvas): 2.2.0
  • Environment (e.g. node 4.2.0 on Mac OS X 10.8): any
@chearon chearon added the Build label Dec 3, 2018
@chearon
Copy link
Collaborator Author

chearon commented Dec 3, 2018

BTW still none of the 2.x build on node 6 / macOS either, although I've never tried to find out why:

ld: library not found for -lstdc++
clang: error: linker command failed with exit code 1 (use -v to see invocation)

@Hakerh400
Copy link
Contributor

Should it be > 7 instead?

Seems correct. I'll open PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants